Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: retain src input amount after switching tokens #29709

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Jan 14, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1798

Manual testing steps

  1. Load bridge page
  2. Select amount, src token and dest token
  3. Click token switch button to swap src and dest selections
  4. Verify that src amount is preserved

Screenshots/Recordings

Before

Amount is cleared

After

Amount is preserved

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae force-pushed the mms1798-preserve-amount-value branch from cb0b6ae to 1922b06 Compare January 14, 2025 19:24
@metamaskbot
Copy link
Collaborator

Builds ready [1922b06]
Page Load Metrics (1633 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34917971565294141
domContentLoaded1415178416099043
load1419180016339445
domInteractive19193423818
backgroundConnect56223199
firstReactRender1688452613
getState44913147
initialActions01000
loadScripts1054137112117536
setupStore6529105
uiStartup16022214190815072
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -38 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae marked this pull request as ready for review January 15, 2025 01:23
@micaelae micaelae requested a review from a team as a code owner January 15, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants